Opened 8 years ago

Closed 8 years ago

#968 closed task (fixed)

Systemd 213 and fsck -l

Reported by: William Harrington Owned by: chris@…
Priority: major Milestone: CLFS Standard 3.0
Component: BOOK Version: CLFS Standard GIT
Keywords: Cc: berzerkula@…, jonathan@…, chris@…

Description

Martin had issues with this release and his system configuration.

http://cgit.freedesktop.org/systemd/systemd/commit/?id=c343be283b7152554bac0c02493a4e1759c163f7

I'm wanting to apply the attached patch to revert (this is reverted in 214) this for 213.

Change History (4)

comment:1 Changed 8 years ago by William Harrington

Attachments are still broke:

diff -Naur systemd-213.orig/TODO systemd-213/TODO
--- systemd-213.orig/TODO       2014-05-22 12:33:11.426602573 +0000
+++ systemd-213/TODO    2014-06-21 02:50:09.709794390 +0000
@@ -1,4 +1,7 @@
 Bugfixes:
+* Re-enable "fsck -l" when it is ready:
+   https://bugs.freedesktop.org/show_bug.cgi?id=79576#c5
+
 * Should systemctl status \* work on all unit types, not just .service?
 
 * enabling an instance unit creates a pointless link, and
diff -Naur systemd-213.orig/src/fsck/fsck.c systemd-213/src/fsck/fsck.c
--- systemd-213.orig/src/fsck/fsck.c    2014-05-22 03:04:17.143835511 +0000
+++ systemd-213/src/fsck/fsck.c 2014-06-21 02:50:09.709794390 +0000
@@ -317,7 +317,18 @@
         cmdline[i++] = "/sbin/fsck";
         cmdline[i++] =  arg_repair;
         cmdline[i++] = "-T";
-        cmdline[i++] = "-l";
+
+        /*
+         * Disable locking which conflict with udev's event
+         * ownershipi, until util-linux moves the flock
+         * synchronization file which prevents multiple fsck running
+         * on the same rotationg media, from the disk device
+         * node to a privately owned regular file.
+         *
+         * https://bugs.freedesktop.org/show_bug.cgi?id=79576#c5
+         *
+         * cmdline[i++] = "-l";
+         */
 
         if (!root_directory)
                 cmdline[i++] = "-M";

comment:2 Changed 8 years ago by chris@…

I had the same problem as Martin, and it was indeed fixed by applying that change. Martin reported that he did not try the patch, but systemd 214, which has that applied, works fine. I think this change can be added to the book as a simple 1-liner sed, as that's all that's really changed other than documentation/comments.

comment:3 Changed 8 years ago by chris@…

Owner: changed from clfs-commits@… to chris@…
Status: newassigned

comment:4 Changed 8 years ago by chris@…

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.