Opened 4 years ago

Closed 4 years ago

#1080 closed task (wontfix)

Use GLIBC xattr for attr tools and acl tools and library

Reported by: William Harrington Owned by: clfs-commits@…
Priority: trivial Milestone: CLFS Standard 3.1.0
Component: BOOK Version: CLFS Standard GIT
Keywords: Cc: berzerkula@…, jonathan@…, chris@…, cross-lfs@…

Description

Chris mentioned to use xattr.h from Glibc to build ACL. We don't need the ATTR package in the book.

Reference: http://lists.gnu.org/archive/html/acl-devel/2014-05/msg00001.html

I've edited some files and have attached a patch to apply to ACL.

Attachments (2)

acl-2.2.52-sys_xattr-1.patch (12.5 KB) - added by William Harrington 4 years ago.
Allows acl to use xattr from libc
attr-2.4.47-sys_xattr-1.patch (4.4 KB) - added by William Harrington 4 years ago.

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by William Harrington

Allows acl to use xattr from libc

comment:1 Changed 4 years ago by William Harrington

Actually, we probably can't remove the ATTR package as we need the attr, getfattr, and setfattr programs and man-pages.

comment:2 Changed 4 years ago by William Harrington

For ATTR, we can build the tools attr, getfattr, setfattr and install the man pages for them and skip installing the headers and libraries.

The tests will work fine. All 114 passed for me.

I've attached a patch for ATTR. This will make intallation of ATTR in all books much shorter and simpler. No need to install libraries. Just have one install of ATTR in each book.

comment:3 Changed 4 years ago by William Harrington

Summary: Remove ATTR package and use GLIBC sys/xattr.hUse GLIBC xattr for attr tools and acl tools and library

Changed 4 years ago by William Harrington

comment:4 Changed 4 years ago by William Harrington

With my server build the following tools link to libattr and means that they may need edits to use <sys/xattr.h> and not attempt to link to libattr with -lattr.

/bin/install
/bin/cp
/bin/mv
/lib/libacl.so.1.1.0
/lib/libcap.so.2.22
/usr/bin/msgfilter
/usr/bin/getfattr
/usr/bin/patch
/usr/bin/msginit
/usr/bin/bsdtar
/usr/bin/chacl
/usr/bin/xgettext
/usr/bin/msgcomm
/usr/bin/msgcmp
/usr/bin/msgfmt
/usr/bin/bsdcpio
/usr/bin/msgcat
/usr/bin/setfacl
/usr/bin/getfacl
/usr/bin/msgmerge
/usr/bin/recode-sr-latin
/usr/bin/msgunfmt
/usr/bin/setfattr
/usr/bin/attr
/usr/bin/xorriso
/usr/bin/msgen
/usr/bin/msgexec
/usr/bin/msggrep
/usr/bin/msgconv
/usr/bin/msgattrib
/usr/bin/msguniq
/usr/lib/python2.7/site-packages/samba/xattr_native.so
/usr/lib/libgettextsrc-0.18.3.so
/usr/lib/libarchive.so.13.1.2
/usr/lib/samba/libntvfs.so
/usr/lib/samba/libsmbd_base.so
/usr/lib/gettext/hostname
/usr/lib/gettext/urlget
/usr/lib/libgettextlib-0.18.3.so
/usr/sbin/proftpd
/usr/sbin/usermod
/usr/sbin/useradd

comment:5 Changed 4 years ago by William Harrington

libcap will need an edit:

sed -i 's/-lattr//' libcap/Makefile

comment:6 Changed 4 years ago by William Harrington

Priority: majortrivial

comment:7 Changed 4 years ago by William Harrington

Shadow needs to be hacked for this. I don't think it is worth all of the effort to edit a bunch of source to use <sys/xattr.h> and change all the configure scripts which are looking for libattr.

comment:8 Changed 4 years ago by Martin Ward

Yes have to agree with your last comment, checked gentoo, arch, fedora, all use stand alone attr lib

comment:9 Changed 4 years ago by William Harrington

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.